Spigot ✨ Amazing Fishing ✨ 1.7.10 - Latest 4.4

Make fishing more interesting !

  1. No, it doesn't work
     
  2. You said the plugin is Open Source
     
  3. Any chance for 1.12.2 support? Hoping to implement fishing into a OP-Prison gamemode.
     
  4. I plan to do support for 1.12.2, Currently I am working on quests, fish of day.. many things

    Edit:
    Discord link: https://discord.gg/Hf49Mm
     
  5. Yeah np! And ill join!
     
  6. hey, I found this crash:
    Code (Text):
    [02:27:10 INFO]: Kubson_ issued server command: /amazingfishing
    [02:27:23 ERROR]: Could not pass event InventoryClickEvent to TheAPI v2.3
    java.lang.NullPointerException: null
            at AmazingFishing.Utils.getGlobalRecords(Utils.java:65) ~[?:?]
            at AmazingFishing.gui.onOpenFish(gui.java:125) ~[?:?]
            at AmazingFishing.gui$7.run(gui.java:113) ~[?:?]
            at me.Straiker123.Utils.punishment.onClick(punishment.java:272) ~[?:?]
            at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor26.execute(Unknown Source) ~[?:?]
            at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.14.4.jar:git-Paper-226]
            at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.14.4.jar:git-Paper-226]
            at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.14.4.jar:git-Paper-226]
            at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:545) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.PlayerConnection.a(PlayerConnection.java:2310) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.PacketPlayInWindowClick.a(SourceFile:33) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.PacketPlayInWindowClick.a(SourceFile:10) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.PlayerConnectionUtils.lambda$ensureMainThread$0(PlayerConnectionUtils.java:23) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.TickTask.run(SourceFile:18) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeTask(IAsyncTaskHandler.java:136) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeNext(IAsyncTaskHandler.java:109) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.MinecraftServer.aX(MinecraftServer.java:1029) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.MinecraftServer.executeNext(MinecraftServer.java:1022) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.IAsyncTaskHandler.executeAll(IAsyncTaskHandler.java:95) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:1158) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:925) ~[patched_1.14.4.jar:git-Paper-226]
            at java.lang.Thread.run(Unknown Source) [?:1.8.0_231]
    Another bug: Players are able to put items in the shop, if you close the shop items disappear.
    Also will you add in a future update a shop editor?

    This one too:
    Code (Text):
    [02:35:43 INFO]: Started tournament type 'Length' on 5min
    [02:36:43 INFO]: Running tournament type 'Length' on 4min
    [02:36:43 WARN]: [AmazingFishing] Task #2240 for AmazingFishing v2.7 generated an exception
    java.lang.IndexOutOfBoundsException: Index: 3, Size: 0
            at java.util.ArrayList.rangeCheck(Unknown Source) ~[?:1.8.0_231]
            at java.util.ArrayList.get(Unknown Source) ~[?:1.8.0_231]
            at AmazingFishing.Tournament$1.run(Tournament.java:266) ~[?:?]
            at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftTask.run(CraftTask.java:84) ~[patched_1.14.4.jar:git-Paper-226]
            at org.bukkit.craftbukkit.v1_14_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:452) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.MinecraftServer.b(MinecraftServer.java:1171) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.DedicatedServer.b(DedicatedServer.java:417) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.MinecraftServer.a(MinecraftServer.java:1098) ~[patched_1.14.4.jar:git-Paper-226]
            at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:925) ~[patched_1.14.4.jar:git-Paper-226]
            at java.lang.Thread.run(Unknown Source) [?:1.8.0_231]
    (The lang files are bit sensitive, sometimes when I reload the Translations file It restarts to as it was by default, of course I'm always checking if there are any missing ')
     
    #33 Kubson_19, Nov 30, 2019
    Last edited: Nov 30, 2019
  7. You can edit items in shop in AmazingFishing-Shop config
     
  8. I Know, but what about ingame editor like adding custom items like from MMoItems it can be done via command but not showing stats.
     
    • Agree Agree x 1
  9. This really seems like a cool plugin and adds some fun to the boring default fishing. However, I have some issues like the tournaments are broken, not a major issue but still would be fun to use them. There is one major issue though, an item dupe glitch using the fish bag.

    When starting a tournament, it always says and sets it to 10 minutes. I also got errors around the 8 minute left mark, but didn't screenshot those.

    When stopping a tournament if gives an error, but says it stopped the tournament. However it does not actually stop the tournament and if you attempt to start another it will say one is already running.
    cmd_YHY8O51Vyg.png



    As for the item dupe glitch it seems to work with stackable items best. For non-stacking items it works on most things as well, except the fishing rod. For stacks it returns double what you put in. So put in 9 diamonds, get 18 back, and keep doubling from there.

    Items I tested and successfully duped:
    - Iron Shovel
    - Carrot on a Stick
    - Diamonds, Salmon, Raw Chicken, Wither Roses, Cobblestone (all stackables)
    - Mending book
    - Legendary LootCrate from another plugin
    - Shears
    - Diamond Pickaxe
    - Diamond Chestplate
    - Diamond Helmet
    - Shulker Box with items inside it, this can be used to dupe the fishing rods that seem to stay in the bag and not duplicate


    Other than these two issues I have one suggestion that would make the GUI a bit nicer and user friendly I think. When you go to look at a record fish, you have to click on them and it shows you in chat what your record is. It would be nice to just be able to hover over that fish in the GUI and see the records there in both size and weight, could even add the total amount of that fish you have caught as well. That way you don't have to click and it close the gui, so you can easily check multiple fish quickly. Then you could also add a extra GUI page for the list of fish to display them visually instead of in chat, could also have it say if you have caught that fish before or not in a hover window. I look forward to seeing how this plugin goes, I'm really liking it and hope to be able to use it on my server at some point. Keep up the good work :)
     
    • Like Like x 1
  10. Please, join to the AF discord group, On it you can get testing versions of AF. https://discord.gg/Hf49Mm
     
  11. Please check Fish Bag, my player can take all stuff in GUI
     
  12. You are using Testing version of Amazing fishing plugin ?
    Whats version of The API you have ?
     
  13. ERROR Could not load 'plugins/AmazingFishing (1).jar' in folder 'plugins'
    04.12 11:52:54 [Server] INFO org.bukkit.plugin.UnknownDependencyException: TheAPI
    04.12 11:52:54 [Server] INFO at org.bukkit.plugin.SimplePluginManager.loadPlugins(SimplePluginManager.java:224) ~[patched_1.14.4.jar:git-Paper-226]
    04.12 11:52:54 [Server] INFO at org.bukkit.craftbukkit.v1_14_R1.CraftServer.loadPlugins(CraftServer.java:355) ~[patched_1.14.4.jar:git-Paper-226]
    04.12 11:52:54 [Server] INFO at net.minecraft.server.v1_14_R1.DedicatedServer.init(DedicatedServer.java:226) ~[patched_1.14.4.jar:git-Paper-226]
    04.12 11:52:54 [Server] INFO at net.minecraft.server.v1_14_R1.MinecraftServer.run(MinecraftServer.java:876) ~[patched_1.14.4.jar:git-Paper-226]
    04.12 11:52:54 [Server] INFO at java.lang.Thread.run(Thread.java:748) [?:1.8.0_144]