Bungee - Spigot BungeeSuite Teleports BungeeSuite PRE v1.0b-01

hello,

i have see in your github commits, the sign updates is in a async task, i think this is not very good idee.

Read in this wiki from bukkit:
http://wiki.bukkit.org/Scheduler_Programming#BukkitScheduler

"Warning: Asynchronous tasks should never access any API in Bukkit"

If you want change the signs on a server, please do it with an sync task or the server can crash.
Suchs errors are hard to find.

Thanks

 

OH LORD, WHAT HAVE I LOOKED AT ! (it's a joke, no offense)
Do note that the problem you have noted n0nick2013 is, I believe, wrong, because the lines are stored as a String on the craftbukkit side, and that's an immutable field, so there can't be concurrent modifications. However, seeing the amount of raw access to hashmaps made... I doubt the code is "thread-safe" at all.

 

I'm not a server owner, so no, but you should really be extra-cautious when dealing with multithreading. Anything that has a state that can internally change (like hashmaps) is prone to bugs. And bukkit API is not thread-safe, as n0nick mentioned.

The easy way out would be to change it to sync. The harder way out would be to synchronize only the bukkit calls, and then make sure everything in your plugin is thread-safe. The super-hard way out would be to make bukkit thread-safe, but good luck with that

 

This plugin requires Vault, please add that to the main page.

It crashes without it.

 

I like the modularization. BungeeSuiteTeleport is really well done.

 

It's also very nice to manage the permissions with bukkit instead of bungee.

 

Do you mind implementing tpahere?
Edit: Meant tphere ;D

 

I beleive he meant tpahere, as in, inverse /tpa (ask a player if he wants to tp to you)

 

Arrrghhh yea sorry ;D haha Ok ty.