Check for permissions e.t.c before cmd or what?

Discussion in 'Spigot Plugin Development' started by NaJated, May 8, 2015.

  1. NaJated

    NaJated

    hey all, should I do this:

    Code (Text):
            if (cmd.getName().equalsIgnoreCase("happyhour")) {
                if (sender.hasPermission("hi.there")) {
                    if (args.length == 0) {
    OR

    Code (Text):
            if (cmd.getName().equalsIgnoreCase("happyhour")) {
                                if (args.length == 0) {
                   if (sender.hasPermission("hi.there")) {
    {
    OR

    Code (Text):

                            if (sender.hasPermission("hi.there")) {
                        if (args[0].equalsIgnoreCase("start")) {

    and What do I do for else statements here?
    Code (Text):
                        if (args[0].equalsIgnoreCase("start") && sender.hasPermission("happyhour.start")) {
     
    #1 NaJated, May 8, 2015
  3. Compilable

    Compilable

    First.
     
    #2 Compilable, May 8, 2015
    • Like Like x 1
  5. Sirenum

    Sirenum

    I usually just check the permission right after the command. It make sense.
     
    #3 Sirenum, May 8, 2015
  7. NaJated

    NaJated

    Okay What about args tho?
     
    #4 NaJated, May 8, 2015
  9. Sirenum

    Sirenum

    Uh well.. What do you mean?

    EDIT:

    This is usually how I check my permissions.

    PHP:
    if(cmd.getName().equalsIgnoreCase("access")) {
     
        if(!sender.hasPermission("access.use")) {
            sender.sendMessage("No permissions.");
        }else {
            //Do allowed functions.
            //Check arguments.
        }
    }
     
    #5 Sirenum, May 8, 2015
    • Like Like x 1
  11. NaJated

    NaJated

    checking for specifc arg permissions.
     
    #6 NaJated, May 8, 2015
  13. Inkzzz

    Inkzzz
    Resource Staff

    Checking form permission(s), with commands and arguments really depends on how many commands you're having. I normally check the argument value, then permission.
     
    #7 Inkzzz, May 8, 2015
    • Like Like x 1
  15. NaJated

    NaJated

    k bbe :D
     
    #8 NaJated, May 8, 2015
  17. DarkSeraphim

    DarkSeraphim

    @IPv420 generally, do the fastest check first, unless you can't (ex. you generally want to group code for a single command together - even though you could just use a separate executor). Checking array length is faster than checking permissions, thus check array length first.
     
    #9 DarkSeraphim, May 9, 2015
    • Like Like x 1
  19. NaJated

    NaJated

    Okay thanks :D
     
    #10 NaJated, May 9, 2015
(You must log in or sign up to post here.)