1. Guest, as per the stickied thread, this forum has not been in use since 2014. All bugs and feature requests should be posted to JIRA.

Rejected ChestShop Item Stacking

Discussion in 'Bugs & Feature Requests' started by Zeokon, Dec 1, 2012.

  1. Reported here : http://dev.bukkit.org/server-mods/chestshop/ (In the comments section)

    as Item Stacking Bug, caused by Bukkit, maybe you could fix it before hand, items can be stacked when bought. Example, Diamond Chestplate.
     
  2. I can not reproduce this on my older version of ChestShop, so it has to be a bug in newer ChestShop

    Author confirms its his bug on ChestShop page. Not a CB or Spigot issue.
     
  3. Unless you were having epileptic seizures it says in the download.


    Source : http://dev.bukkit.org/server-mods/chestshop/files/36-v3-50-t0035-test-version/

    Worked around the item stacking bug in Bukkit (it still need to be fixed in Bukkit, but as of now, the items like potions won't be stacked anymore)

    But the bug is still there.
     
    • Funny Funny x 1
  4. Because the author is wrong, look at his fix:

    https://github.com/Acrobot/ChestShop-3/commit/69e08d0c7dfb7dc2a56c77146fa2f158ed3de60b

    His change applies to the code that handles a single item stack. Under NORMAL conditions of vanilla gameplay, itemstacks should not exceed their stack size.

    A pickaxe should only be passed with itemstack.count=1

    For this to be happening, that means the author is creating an itemstack with a count greater than the maximum and passing it to inventory.addItem

    The ability to exceed the max stack size is a feature plugins can use, but in this case he is mistakenly doing it.

    As I said before, I use an older chest shop and this problem does not occur.

    If I buy 3 diamond chests from 1 purchase, I get 3 single items.

    I'm betting he just created an item stack with the item to buy, set count to be the # of being bought, and now this is happening.

    Bukkit WILL NOT change this behavior. The author has to fix it himself by not creating itemstacks of a count greater than their max stack size.