getOnlinePlayers doesn't work in 1.7 protocol hack?

I believe for most 1.7 versions, getOnlinePlayers() is deprecated.

 

It worked for me when I used it.. Is there something in your code preventing it from reaching it?

 

What version do you compile against?

 

Bukkit version

 

I thought they meant 1.7.2 and 1.6.4 :facepalm:

 

Maybe you compile against minecraft 1.8 and the compiler uses the version of getOnlinePlayers() that returns an array.
Wouldn't that cause a NoSuchMethodException?

 

Yes.

 

Then i'm stumped.

 

Well it works for me, so all that can be assumed is user error. More code would be nice, because it's certainly a problem with the surrounding code, not the #getOnlinePlayers call itself.

 

For me I really don't like using deprecated code, so I fastly made my own getOnlinePlayers() Method. If you want, you can use it:

Code (Text):

public List<Player> getOnlinePlayers() {
     List<Player> players = new ArrayList<Player>();
     for(World world : Bukkit.getWorlds()) {
          for(Player player : world.getPlayers()) {
               players.add(player);
          }
     }
     return players;
}

I hope I could help you!

~ Sorry for my english
CBPlugins

 

That's a much, much slower method than using Bukkit#getOnlinePlayers (which OP really isn't having a problem with anyhow)

 

#getOnlinePlayers is not deprecated, the return value was just changed in the 1.8 update.


It now returns a Collection by default, but you can still use #toArray()

and OP, https://hub.spigotmc.org/jira/browse/SPIGOT-103

 

Yes you are right

But I thought @TheTrollzJ 's code is not working on the #getOnlinePlayers Methode in the 1.7 protocol hack version of spigot. And with the code snippet I posted it should definitly work fine.

 

The problem isn't with #getOnlinePlayers, it's completely different. We just don't have context because more code hasn't been posted.

 

Well, they did give us code:

Code (Java):

for(Player p : Bukkit.getOnlinePlayers()){
// code
}

Maybe he thinks the compiler magically turns //code into whatever he wants!

 

Make sure you are importing from bukkit and not craftbukkit, this is because CB returns both an array of online players and a collection, which causes a conflict.

 

There's literally nothing wrong with the posted code. We haven't seen the problem yet.