Solved Getting JavaPlugin from other class doesn't work?

Maybe this line is executed too early:

Code (Text):

public static main plugin = (main)Bukkit.getPluginManager().getPlugin("main");

Try something like this in your onEnable method:

Code (Text):

onEnable() {
  this.plugin = this;
}

 

Code (Text):

JavaPlugin.getProvidingPlugin(main.class)

Code (Text):

 
new BukkitRunnable() {
  public void run() {
    cancel();
   }
}.runTaskLater(JavaPlugin.getProvidingPlugin(main.class), delay);

 

That's incredibly slow in comparison to using good design like dependency injection. That forces a map lookup.

Edit: Doesn't cause a map lookup anymore. Doesn't forsake design principles however.

 

Wouldn't compile...

 

It's not meant to, it's an example.

 

Yeah sure, but not giving some code is different from giving bad code. User called this.plugin when plugin is public static.

 

That is not how you are suppose to handel things!!!!! *shivers*

Either do what @1Rogue said or pass the reference in a constructutor which I recommend.

Code (Text):

onEnable() {
    new Time(this);
}

public class Time {
    private final Plugin plugin;

    public Time(Plugin plugin) {
        this.plugin = plugin;
    }
}

 

I think that you should see the implementation.

 

Implementation


Perf test

 

Read that wrong...

Yes you can do that too I use that all the time

 

Ah nice, that's smarter than what it used to be.

 

Whats the problem with it? That's a normal singleton design and would compile perfectly fine (of course a getter method would be more appropriate rather than making it public).

 

Code (Java):

private static Main instance = null;
public void onEnable() {
   instance = this;
}

public static Main getInstance() {
return instance;
}

Code (Java):

new BukkitRunnable() {
  public void run() {
    cancel();
   }
}.runTaskLater(Main.getInstance(), delay);

or

Code (Java):

// Main class
public void onEnable() {
  OtherClass class = new OtherClass(this);
}

Code (Java):

public class OtherClass {
  private Main plugin;
  public OtherClass(Main main) {
   plugin = main;
  }

    new BukkitRunnable() {
    public void run() {
     cancel();
    }
  }.runTaskLater(plugin, delay);

}

 

Ah, Spigot's favourite design pattern.

 

It would, it's just a bit silly to be accessing a static variable using this.

 

*leaves*

http://www.javatpoint.com/java-naming-conventions