1.14.4 Ghost Items with Inventories

ArKeid0s · Jan 18, 2020

Hello, I have a very strange bug with inventories.
Here are my events related to my menus :

Code (YAML):

public class menuHandler implements Listener {

mainclass plugin;

public menuHandler(mainclass mainclass) {
mainclass = plugin;
}

@EventHandler
public void onInvClick(InventoryClickEvent event) {
Player player = (Player) event.getWhoClicked();
Inventory open = event.getClickedInventory();
ItemStack item = event.getCurrentItem();

if(open == null) {
return;
}

//Define what each item in the main menu does
if(event.getView().getTitle().equals(menusClass.invMainMenuName)) {
event.setCancelled(true);
if(item == null || !item.hasItemMeta()) {
return;
}

//Create your pet
if(item.getItemMeta().getDisplayName().equals(menusClass.petItemCrea)) {
player.sendMessage("§aCreate your pet");
//Open the pet creation menu
menusClass petCreationMenu = new menusClass();
event.setCancelled(true);
player.closeInventory();
petCreationMenu.createPetCreationMenu(player);
}

//Edit your pet
if(item.getItemMeta().getDisplayName().equals(menusClass.petItemEdit)) {
player.sendMessage("§bEdit your pet");
event.setCancelled(true);
player.closeInventory();
}

//Remove your pet
if(item.getItemMeta().getDisplayName().equals(menusClass.petRemoveItem)) {
//Bukkit.getServer().dispatchCommand(event.getWhoClicked(), Commands.cmd); Execute une commande
player.sendMessage("§dRemove your pet");
player.closeInventory();
}

//Close the menu
if(item.getItemMeta().getDisplayName().equals(menusClass.petCloseItem)) {
player.closeInventory();
}
}

//Define what each item in the creation menu does
if(event.getView().getTitle().equals(menusClass.invCreaMenuName)) {
event.setCancelled(true);
if(item == null || !item.hasItemMeta()) {
return;
}
}
}

}

As you can see events are canceled but if you look the screenshots :

I can pick up items by shift-clicking but they are not considered as items until I open my vanilla inventory.
I noticed that this bug appears when i use the player.closeInventory(); but also with event.getView().close();

Can someone help me with that?

Thanks, ArKeid0s

Schottky · Jan 18, 2020

From the docs:

Because InventoryClickEvent occurs within a modification of the Inventory, not all Inventory related methods are safe to use.

The following should never be invoked by an EventHandler for InventoryClickEvent using the HumanEntity or InventoryView associated with this event:

HumanEntity.closeInventory()

HumanEntity.openInventory(Inventory)

HumanEntity.openWorkbench(Location, boolean)

HumanEntity.openEnchanting(Location, boolean)

InventoryView.close()

To invoke one of these methods, schedule a task using BukkitScheduler.runTask(Plugin, Runnable), which will run the task on the next tick. Also be aware that this is not an exhaustive list, and other methods could potentially create issues as well.
Click to expand...

Also, could you elaborate what the expected behaviour is?

ArKeid0s · Jan 18, 2020

I wanted to send a player message when i click on the item and then close the inventory when the item is clicked, it is working fine but when i shift click it is buggy

Schottky · Jan 18, 2020

welp, did you try and close the inventory one tick later as mentioned above?

ArKeid0s · Jan 18, 2020

nop not for now I i quite new to plugin dev I do not know how to achieve that ^^

Schottky · Jan 18, 2020

Instead of player.closeInventory(), do the following:

Code (Java):

Bukkit.getScheduler().runTaskLater(plugin, player::closeInventory, 1L);

This is already a somewhat advanced method (nothing too wild, but it might confuse you when you are new), so if you want to understand what is going on, use this:

Code (Java):

Bukkit.getScheduler().runTaskLater(plugin, new Runnable() {
@Override
public void run() {
player.closeInventory();
}
}, 1L);

Both are equivalent to each other, the first however is more elegant since you only need one line.

robertlit · Jan 18, 2020

Schottky said: ↑

Instead of player.closeInventory(), do the following:

Code (Java):

Bukkit.getScheduler().runTaskLater(plugin, player::closeInventory, 1L);

This is already a somewhat advanced method (nothing too wild, but it might confuse you when you are new), so if you want to understand what is going on, use this:

Code (Java):

Bukkit.getScheduler().runTaskLater(plugin, new Runnable() {
@Override
public void run() {
player.closeInventory();
}
}, 1L);

Both are equivalent to each other, the first however is more elegant since you only need one line.
Click to expand...

Actually there is no need to use #runTaskLater with 1 tick, you can just use #runTask and the task will be run in the next tick

ArKeid0s · Jan 18, 2020

To what the 1L corresponds to?
And could you provide me the link to the docs that you gave me earlier please it is very useful

Schottky · Jan 18, 2020

robertlit said: ↑

Actually there is no need to use #runTaskLater with 1 tick, you can just use #runTask and the task will be run in the next tick
Click to expand...

Interesting. Are the two options equivalent otherwise? In other words, is there any difference in whether I'd call runTaskLater with 1 tick or simply runTasks?

Schottky · Jan 18, 2020

ArKeid0s said: ↑

To what the 1L corresponds to?
And could you provide me the link to the docs that you gave me earlier please it is very useful
Click to expand...

1L means delay for one tick. Since the value is a signed long, you have to provide that value (in most cases you could also write 1, depends on the compiler I think)
Here's the link
https://hub.spigotmc.org/javadocs/spigot/org/bukkit/event/inventory/InventoryClickEvent.html

robertlit · Jan 18, 2020

Schottky said: ↑

Interesting. Are the two options equivalent otherwise? In other words, is there any difference in whether I'd call runTaskLater with 1 tick or simply runTasks?
Click to expand...

Not sure. They are probably equivalent.

ArKeid0s · Jan 18, 2020

Okay guys thanks a lot for your help I will try that later I'll tell you if it is working

ArKeid0s · Jan 18, 2020

Hmm it is not working :/

ArKeid0s · Jan 18, 2020

I have this error in the console

Code (Text):

18.01 16:13:58 [Server] Server thread/ERROR Could not pass event InventoryClickEvent to ArkPets v0.1
18.01 16:13:58 [Server] INFO org.bukkit.event.EventException: null
18.01 16:13:58 [Server] INFO at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:320) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:529) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:514) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.PlayerConnection.a(PlayerConnection.java:2147) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.PacketPlayInWindowClick.a(SourceFile:32) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.PacketPlayInWindowClick.a(SourceFile:10) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.PlayerConnectionUtils.lambda$0(PlayerConnectionUtils.java:19) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.TickTask.run(SourceFile:18) [spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeTask(SourceFile:144) [spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.IAsyncTaskHandlerReentrant.executeTask(SourceFile:23) [spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.executeNext(SourceFile:118) [spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.MinecraftServer.aZ(MinecraftServer.java:917) [spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.MinecraftServer.executeNext(MinecraftServer.java:910) [spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.IAsyncTaskHandler.awaitTasks(SourceFile:127) [spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.MinecraftServer.sleepForTick(MinecraftServer.java:894) [spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at net.minecraft.server.v1_15_R1.MinecraftServer.run(MinecraftServer.java:827) [spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at java.lang.Thread.run(Thread.java:748) [?:1.8.0_232]
18.01 16:13:58 [Server] INFO Caused by: java.lang.IllegalArgumentException: Plugin cannot be null
18.01 16:13:58 [Server] INFO at org.apache.commons.lang.Validate.notNull(Validate.java:192) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftScheduler.validate(CraftScheduler.java:443) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftScheduler.runTaskTimer(CraftScheduler.java:176) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftScheduler.runTaskTimer(CraftScheduler.java:167) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftScheduler.runTaskLater(CraftScheduler.java:131) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at org.bukkit.craftbukkit.v1_15_R1.scheduler.CraftScheduler.runTask(CraftScheduler.java:100) ~[spigot-1.15.1.jar:git-Spigot-2ee05fe-d31f05f]
18.01 16:13:58 [Server] INFO at fr.arkeidos.arkpets.menuHandler.onInvClick(menuHandler.java:59) ~[?:?]
18.01 16:13:58 [Server] INFO at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_232]
18.01 16:13:58 [Server] INFO at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_232]

Schottky · Jan 18, 2020

well... where I put plugin, you need to insert an Instance of your Main-class (the class that extends JavaPlugin).

ArKeid0s · Jan 18, 2020

Code (YAML):

public class menuHandler implements Listener {

mainclass plugin;

public menuHandler(mainclass mainclass) {
mainclass = plugin;
}

You are talking about that ?

Schottky · Jan 18, 2020

The class that extends JavaPlugin, probably mainclass, maybe not

ArKeid0s · Jan 18, 2020

yes it is mainclass that extends JavaPlugin but as you can see normally my plugin variable corresponds to that no ?

Schottky · Jan 18, 2020

I theory, yes. The problem that you have is, that your variable is null. Try to find out where you set that and why that is null. Maybe you have passed some invalid reference into the constructor?

ArKeid0s · Jan 18, 2020

I'm so fucking dumb sorry .... I found my mistake i did mainclass = plugin in the constructor instead of plugin = mainclass

Useful Searches

1.14.4 Ghost Items with Inventories