How to prevent stealing from inventory

Discussion in 'Spigot Plugin Development' started by Kyllian, Apr 14, 2017.

Page 1 of 2
  1. Kyllian

    Kyllian

    Hey,

    This is my code:

    Code (Text):
    @EventHandler
        public void onInventoryClickEvent(InventoryClickEvent e) {
            if (e.getInventory() instanceof CraftingInventory) {
                if (e.getCurrentItem().getType() == Material.BARRIER) {
                    e.setCancelled(true);
                    return;
                }
            }
        }
    There is one problem. When I jitterclick and close the inventory I can get the barrier out of the inventory. How can I disable/prevent this?
     
    #1 Kyllian, Apr 14, 2017
  3. Nosmakos

    Nosmakos

    CraftingInventory
    I am pretty sure it's PlayerInventory
     
    #2 Nosmakos, Apr 14, 2017
  5. Kyllian

    Kyllian

    I'm pretty sure it's not.

    I forgot to mention that I want it to work on workbenches only (And maybe player crafting thingys)
     
    #3 Kyllian, Apr 14, 2017
  7. ICrotz

    ICrotz

    just do
    e.getInventory().equals(e.getWhoClicked().getInventory())

    and check e.getInventory() != null before
     
    #4 ICrotz, Apr 14, 2017
  9. Nosmakos

    Nosmakos

    Then check if the inventory is clicked equals to the inventory you want
     
    #5 Nosmakos, Apr 14, 2017
  11. Kyllian

    Kyllian

    But that still doesnt prevent it from stealing

    Because the event gets canceled but when i click fast im able to craft the item
     
    #6 Kyllian, Apr 14, 2017
  13. iTouchedTrump

    iTouchedTrump

    You could try changing the event priority to run first, and then cancel it at the very beginning of the event. Then don't cancel it if it is not in the circumstance you want.
     
    #7 iTouchedTrump, Apr 14, 2017
  15. Kyllian

    Kyllian

    Like this?
    Code (Text):
        @EventHandler(priority = EventPriority.HIGHEST)
        public void onInventoryClickEvent(InventoryClickEvent e) {
            e.setCancelled(true);
            if (e.getInventory() instanceof CraftingInventory) {
                if (e.getCurrentItem().getType() == Material.BARRIER) {
                    e.setCancelled(true);
                    return;
                }
            }
            e.setCancelled(false);
        }
    }
     
    #8 Kyllian, Apr 14, 2017
  17. iTouchedTrump

    iTouchedTrump

    Yes, that should work
     
    #9 iTouchedTrump, Apr 14, 2017
    • Winner Winner x 1
  19. Synapz

    Synapz

    [​IMG]
     
    #10 Synapz, Apr 14, 2017
    • Funny Funny x 1
  21. iTouchedTrump

    iTouchedTrump

    [​IMG]
     
    #11 iTouchedTrump, Apr 14, 2017
    • Funny Funny x 1
  23. Nosmakos

    Nosmakos

    tumblr_lpbwptqG331qio765o1_500.gif
     
    #12 Nosmakos, Apr 14, 2017
    • Agree Agree x 1
  25. Synapz

    Synapz

    [​IMG]
     
    #13 Synapz, Apr 14, 2017
  27. Kyllian

    Kyllian

    [​IMG]
     
    #14 Kyllian, Apr 14, 2017
  29. ICrotz

    ICrotz

    Code (Text):
    @EventHandler
        public void onPlayerBarrier(InventoryClickEvent e) {
            if (e.getClickedInventory() == null) return;
            if (!(e.getWhoClicked() instanceof Player)) return;
            Player player = (Player) e.getWhoClicked();
            if (!e.getClickedInventory().equals(player.getInventory())) return;
            ItemStack item = e.getCurrentItem();
            if (item == null) return;
            if (item.getType() == Material.AIR) return;
         
            // DO YOUR OTHER TEST HERE
         
            if (item.getType() == Material.BARRIER) {
                e.setCancelled(true);
            }
        }
    use this code it's work
     
    #15 ICrotz, Apr 14, 2017
  31. Kyllian

    Kyllian

    Hey thanks for the code :D

    But I made this:

    Code (Text):
    @EventHandler(priority = EventPriority.HIGHEST)
        public void onInventoryClickEvent(InventoryClickEvent e) {
            e.setCancelled(true);
                if (e.getCurrentItem().getType() == Material.BARRIER) {
                    if (e.getCurrentItem().hasItemMeta()) {
                        if (e.getCurrentItem().getItemMeta().getDisplayName().equals(ct.cc(main.getConfig().getString("CannotCraftItemName")))) {
                            return;
                        }
                    }
                }
            e.setCancelled(false);
        }
    }
    Is this any better?
     
    #16 Kyllian, Apr 14, 2017
  33. ICrotz

    ICrotz

    some error you forgot to check if inventory is null or item is null
     
    #17 ICrotz, Apr 14, 2017
  35. ICrotz

    ICrotz

    and don't check the config every time, cache data in variable
     
    #18 ICrotz, Apr 14, 2017
  37. iTouchedTrump

    iTouchedTrump

    The code will work, except you need to check if the current item is null
     
    #19 iTouchedTrump, Apr 14, 2017
  39. Kyllian

    Kyllian

    But, How can you click something if you dont have an inventory open (aka null)
     
    #20 Kyllian, Apr 14, 2017
(You must log in or sign up to post here.)
Page 1 of 2