Some feedback for my new plugin?

Naming conventions

 

He was probably talking about class/variable names...

 

http://www.oracle.com/technetwork/java/codeconventions-135099.html

 

http://www.oracle.com/technetwork/java/codeconventions-135099.html

@Skionz dammit

 

Static getInstance method....

 

You do not get downloads because you made a plugin for something that already exist. Is not hard to set whitelist to true, set another icon and motd. Try to make something that you can't do without plugin, then you will get downloads.

 

Not a fan of singleton methods, also in the SettingsManager why is there a Plugin p that is never initialized? You are circling around just using plugin#getConfig(), by which you are instead putting it into the SettingsManager and requiring its use. saveConfig() and reloadConfig() are already methods in Bukkit... https://hub.spigotmc.org/javadocs/spigot/org/bukkit/plugin/Plugin.html

Or am I wrong in something there?

 

...

Yeah, I would honestly suggest against using others code and for experience sake code your own settings manager.
In the onEnable you ignore your own settingsmanager and use bukkit methods, which is correct but shows that there is no real point in having superfluous methods in your code:


Also that saveConfig() position bugs me more than it should; but that's just me I guess

 

@Puddanator

• Don't use Bukkit.getLogger(), use JavaPlugin#getLogger().
• You should use the appropiate access modifiers for your fields - the majority of them (in most projects) should be private.
• Cache your fields! No need to read it from the config each time.
• Like mentioned before, static abuse. You can simply pass the plugin instance ('this' in your main class) through the constructor of another class. (the singleton design pattern should not be used if better alternatives are available)

 

Quality code takes priority over features.