Stripping Down EntityDamageEvent - DamageModifier

One use would be making a magic-resist armor (check if damage == magic, then reduce it). But remove it if its broken and impossible to fix

 

Then you could check if the damage cause is magic (I believe there is something like that) and then reduce the damage ;3

I believe I once used it for a plugin request, but I can't quite member what it was. I think the feature should still be removed though, as it would reduce your workload and evades more bugs and inconsistencies

 

I've messed around with this API before, didn't find any good use case for it.
It seems like an over-complicated solution to a problem noone is having.

I support removing it.

 

I use it for custom mobs. When a player is attacked I look at the mob name, then look in an enum for the damage that mob does and change the damage to that value. (I'm open to any other ways of doing it, even if it involves NBT tags)

 

I thought you were talking about anything related to EntityDamageEvent#getDamage(), setDamage(), Player#getLastDamageCause(), Player#setLastDamageCause(), Player#getLastDamage() and Player#setLastDamage(). If those methods stay I'm happy!

 

It is a great API, take my word for that, but there is just about nobody that actually uses it for production.
If anything, we'll just mess about with NMS to set the damage permanently.

Supporting to remove.

 

Anything that requires "just messing with NMS" should be implemented in the API/an external library...

Anyways as long as you can simply override the total damage value I don't see a problem.

 

It's as simple as: how does it even get used?
Like, nobody uses it. Nobody knows what to use it for. Nobody knows how to use it.
I don't see the point in having it at all, personally. If it just gets broken, remove it.
We'll find alternatives ourselves.

 

I Agree. I have never used this in any of my work.

 

I think most of us know exactly what you're talking about. It makes sense for the data to be in the event. The data should be in the event! But because not a lot of people are actually using it, the time spent maintaining this thing can be focused on something more important.

I don't think accessing the data will be easy without the EntityDamageEvent.DamageModifier, but I'm sure people can manage without it.

It's up to the development team to weigh the cost of maintaining this part, not us.

 

I used it in the past to remove all damage reduction effects from armor. The armor is than used for the visual appearance of the player only.

And in one minigame plugin I let the server admin configure what damage modifiers are applied. I have no data though how much this is used.

So for those uses cases it would be sufficient to be able to change the values for the different DamageModifiers to 0.0D. Not sure if that would make the implementation any simpler.

 

If it is removed what are we going to use instead? If we need to do something when something is damage.

 

Thx

 

But speaking of NMS is there not a way spigot can add a more simple API for it? @Dablakbandit did this with his huge API but it would be even cooler if spigot did this, it would save so much time and it would be neat to make NMS custom entity's with pathfinding and more with an actual API.