Solved Syntax Help

Discussion in 'Spigot Plugin Development' started by LoxleyShadow, Oct 14, 2018.

Thread Status:
Not open for further replies.
Page 1 of 2
  1. LoxleyShadow

    LoxleyShadow

    Note: Line 33 is my problem.

    Code (Java):
    package loxleyshadow.plugin.event.block;

    import java.util.List;

    import org.bukkit.Material;
    import org.bukkit.block.Block;
    import org.bukkit.entity.Player;
    import org.bukkit.event.EventHandler;
    import org.bukkit.event.Listener;
    import org.bukkit.event.block.BlockBreakEvent;

    import loxleyshadow.plugin.Plugin;
    import net.md_5.bungee.api.ChatColor;

    public class BlockBreak implements Listener{
     
        private Plugin plugin;
     
        public void Plugin(Plugin pl) {
            plugin = pl;
        }
     
        List<String> blacklistedBlocks = plugin.getConfig().getStringList("Breakable Blocks");
     
        @EventHandler
        public void onBlockBreak(BlockBreakEvent event) {
            Player player = event.getPlayer();
         
            Block block = event.getBlock();
            Material material = block.getType();
         
            for(String thing : blacklistedBlocks) {
                if(material != Material.thing) {
                    event.setCancelled(true);
                    player.sendMessage(ChatColor.RED + "You cannot break this block!");
                }
            }
        }
    }
     

    I am unfamiliar with Java so can anyone give me some pointers on how to get this configuration file integrated with my plugin?
     
    #1 LoxleyShadow, Oct 14, 2018
  3. natekfl

    natekfl

    Do away with the for loop. Since the string array blacklistedBlocks presumably contains a list of the blocks which you do not want people to break, simply check if blacklistedBlocks.contains(material.toString()), then cancel the event if it does.
     
    #2 natekfl, Oct 14, 2018
    • Useful Useful x 1
  5. LoxleyShadow

    LoxleyShadow

    Thanks. I will try that right now
     
    #3 LoxleyShadow, Oct 14, 2018
  7. LoxleyShadow

    LoxleyShadow

    Code (Java):
            if(blacklistedBlocks.contains(material.toString())) {
                event.setCancelled(true);
                player.sendMessage(ChatColor.RED + "You cannot break this block!");
            }
    Like this?
     
    #4 LoxleyShadow, Oct 14, 2018
  9. iFighter

    iFighter

    It's not that difficult take a look at my sample code.
    Code (Java):
            Material material = Material.DIAMOND_BLOCK; //Broken block
            YamlConfiguration configuration = new YamlConfiguration();
            //configuration.load(file); Load your config here
            List<String> rawBlockedItems = (List<String>) configuration.getList("blockedItems");
            List<Material> blockedItems = rawBlockedItems.stream().map(Material::getMaterial).collect(Collectors.toList()); //Converting list elements to materials
            if(blockedItems.contains(material)){
                //Logic for blocked Items
            }
    Your config would look something like this:

    Code (YAML):
    blockedItems:
      - DIAMOND_BLOCK
     - more blocks
     
    #5 iFighter, Oct 14, 2018
    • Useful Useful x 1
  11. iFighter

    iFighter

    You should load the config once like you did in your example code. The reason why your code won't compile is because you can't get an enum value with a variable directly.

    Material.variable -> will not work
    Material.valueOf(variable) -> works for all enums
    Material.getMaterial(variable) -> works for materials, recommended method
     
    #6 iFighter, Oct 14, 2018
  13. LoxleyShadow

    LoxleyShadow

    Thank you. I will test it out in my test spigot server.
     
    #7 LoxleyShadow, Oct 14, 2018
  15. Jamdoggy

    Jamdoggy

    Also, you config file is somewhat confused...
    You are getting 'Breakable Blocks' from the config file, to populate a list of 'Unbreakable Blocks'.
    This seems like a recipe for disaster...
     
    #8 Jamdoggy, Oct 14, 2018
  17. LoxleyShadow

    LoxleyShadow

    Code (Java):
    package loxleyshadow.plugin.event.block;

    import java.util.List;

    import org.bukkit.Material;
    import org.bukkit.block.Block;
    import org.bukkit.entity.Player;
    import org.bukkit.event.EventHandler;
    import org.bukkit.event.Listener;
    import org.bukkit.event.block.BlockBreakEvent;

    import loxleyshadow.plugin.Plugin;
    import net.md_5.bungee.api.ChatColor;

    public class BlockBreak implements Listener{
       
        private Plugin plugin;
       
        public void Plugin(Plugin pl) {
            plugin = pl;
        }
       
        List<String> blacklistedBlocks = plugin.getConfig().getStringList("Breakable Blocks");
       
        @EventHandler
        public void onBlockBreak(BlockBreakEvent event) {
            Player player = event.getPlayer();
           
            Block block = event.getBlock();
            Material material = block.getType();
           
            if(blacklistedBlocks.contains(material.toString())) {
                event.setCancelled(true);
                player.sendMessage(ChatColor.RED + "You cannot break this block!");
            }
        }
    }
     

    Will this code work?
     
    #9 LoxleyShadow, Oct 14, 2018
  19. LoxleyShadow

    LoxleyShadow

    It worked when there was no config. I just blacklisted Material.GRASS. Now I want to blacklist all the stuff in the config where it is in the format of a list.
     
    #10 LoxleyShadow, Oct 14, 2018
  21. LoxleyShadow

    LoxleyShadow

    Tried the above and got this:
    Code (Java):
    [12:21:47 ERROR]: Error occurred while enabling Blacklist v1.12.2 (Is it up to date?)
    java.lang.NullPointerException: null
        at loxleyshadow.plugin.event.block.BlockBreak.<init>(BlockBreak.java:23) ~[?:?]
        at loxleyshadow.plugin.Plugin.registerEvents(Plugin.java:43) ~[?:?]
        at loxleyshadow.plugin.Plugin.onEnable(Plugin.java:22) ~[?:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:264) ~[spigot.jar:git-Spigot-dcd1643-e60fc34]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:337) [spigot.jar:git-Spigot-dcd1643-e60fc34]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:403) [spigot.jar:git-Spigot-dcd1643-e60fc34]
        at org.bukkit.craftbukkit.v1_12_R1.CraftServer.enablePlugin(CraftServer.java:381) [spigot.jar:git-Spigot-dcd1643-e60fc34]
        at org.bukkit.craftbukkit.v1_12_R1.CraftServer.enablePlugins(CraftServer.java:330) [spigot.jar:git-Spigot-dcd1643-e60fc34]
        at net.minecraft.server.v1_12_R1.MinecraftServer.t(MinecraftServer.java:422) [spigot.jar:git-Spigot-dcd1643-e60fc34]
        at net.minecraft.server.v1_12_R1.MinecraftServer.l(MinecraftServer.java:383) [spigot.jar:git-Spigot-dcd1643-e60fc34]
        at net.minecraft.server.v1_12_R1.MinecraftServer.a(MinecraftServer.java:338) [spigot.jar:git-Spigot-dcd1643-e60fc34]
        at net.minecraft.server.v1_12_R1.DedicatedServer.init(DedicatedServer.java:272) [spigot.jar:git-Spigot-dcd1643-e60fc34]
        at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:545) [spigot.jar:git-Spigot-dcd1643-e60fc34]
        at java.lang.Thread.run(Thread.java:844) [?:?]
     
    #11 LoxleyShadow, Oct 14, 2018
  23. Shin1gamiX

    Shin1gamiX

    What does your config look like?
     
    #12 Shin1gamiX, Oct 14, 2018
  25. iFighter

    iFighter

    No, because you can't use spaces in your config keys.
    Breakable Blocks -> BreakableBlocks

    The only thing I can imagine is that your path for the config is wrong.
     
    #13 iFighter, Oct 14, 2018
    Last edited: Oct 14, 2018
  27. Shin1gamiX

    Shin1gamiX

    You sure can.
     
    #14 Shin1gamiX, Oct 14, 2018
  29. iFighter

    iFighter

    Ty, you are right. Fixed my post.
     
    #15 iFighter, Oct 14, 2018
  31. Shin1gamiX

    Shin1gamiX

    Code (Java):

        private Plugin plugin;
     
        public void Plugin(Plugin pl) {
            plugin = pl;
        }
     
    Did you mean to use a dependency injection for the BlockBreak class? If so, the constructor should be named after your class and your plugin variable should be final.
     
    #16 Shin1gamiX, Oct 14, 2018
  33. LoxleyShadow

    LoxleyShadow

    Code (YAML):
    blockedItems:  
        - GRASS      
        - STONE  
     
    #17 LoxleyShadow, Oct 14, 2018
  35. Shin1gamiX

    Shin1gamiX

    Code (Java):

    plugin.getConfig().getStringList("Breakable Blocks");
     
    This is obvious isn't it?
    Code (Text):
    blockedItems:  
        - GRASS      
        - STONE
    The path "Breakable Blocks" doesn't exist and therefore #getStringList returns null. A valid path is "blockedItems"
     
    #18 Shin1gamiX, Oct 14, 2018
    • Agree Agree x 1
  37. Shin1gamiX

    Shin1gamiX

    Remove: List<String> blacklistedBlocks = plugin.getConfig().getStringList("Breakable Blocks");

    This:
    Code (Java):
    List<String> rawBlockedItems = (List<String>) configuration.getList("blockedItems");
    Should be:
    Code (Java):

    final List<String> rawBlockedItems = configuration.getStringList("blockedItems");
     
     
    #19 Shin1gamiX, Oct 14, 2018
    • Useful Useful x 1
  39. LoxleyShadow

    LoxleyShadow

    Screen Shot 2018-10-14 at 1.46.34 PM.png



    This is my code that still throws the same error
     
    #20 LoxleyShadow, Oct 14, 2018
Page 1 of 2
Thread Status:
Not open for further replies.

Share This Page