Solved TabExecutor not working as intended

I have a class called 'Balance' that implements 'TabExecutor'. In the class I have the onTabComplete and onCommand method. I have registered the 'Balance' class in my onEnable. For some reason the onTabComplete does not work, but the onCommand method does work. Can anyone see what I might be missing?

Here is my onEnable method:

Code (Text):

 public void onEnable() {
        configManager = new MyConfigManager(this);
        playerEconomyData = configManager.getNewConfig("PlayerEconomyData.yml");
        messages = configManager.getNewConfig("Messages.yml");

        Bukkit.getPluginManager().registerEvents(new PlayerJoin(), this);
       
        getCommand("Economy").setTabCompleter(new Balance());
        getCommand("Economy").setExecutor(new Balance());

        loadEconomy();
    }

Here is my Balance class:

Code (Text):

public class Balance implements TabExecutor {
    Main main = Main.getMain();

    @Override
    public List<String> onTabComplete(CommandSender sender, Command command, String label, String[] args) {
        List<String> rList = new ArrayList<>();

        if (args.length == 0) {
            rList.add("Balance");
            return rList;
        }

        return null;
    }

    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {

        if (args.length == 0) {
            //TODO Add args error message
            return false;
        }

        if (args[0].equalsIgnoreCase("Balance") || args[0].equalsIgnoreCase("Bal")) {
            //== /Economy Balance

            if (args.length > 1) {
                //TODO Add args too long error
                return false;
            }

            if (!(sender instanceof Player)) {
                //TODO Add not player error
                return false;
            }

            Player p = (Player) sender;

            if (!main.playerWalletMap.containsKey(p.getUniqueId())) {
                //TODO Add no economy data error
                return false;
            }

            p.sendMessage(main.playerWalletMap.get(p.getUniqueId()).getCurrency().toString());
            return true;
        }

        return false;
    }
}

Thanks is advance

 

I don't seem to have CmdManager. I also should have said that I've tried using the .setTabCompleter() with two separate classes using CommandExecuter and TabCompleter, as well as merging them as I've shown with TabExecutor.

 

TabExecutor class. I've tried separating these two and have one class implement CommandExecutor and one implement TabCompletor as well.

Code (Text):

public class Balance implements TabExecutor {
    Main main = Main.getMain();

    @Override
    public List<String> onTabComplete(CommandSender sender, Command command, String label, String[] args) {
        List<String> rList = new ArrayList<>();

        if (args.length == 0) {
            rList.add("Balance");
            return rList;
        }

        return null;
    }

    public boolean onCommand(CommandSender sender, Command command, String label, String[] args) {

        if (args.length == 0) {
            //TODO Add args error message
            return false;
        }

        if (args[0].equalsIgnoreCase("Balance") || args[0].equalsIgnoreCase("Bal")) {
            //== /Economy Balance

            if (args.length > 1) {
                //TODO Add args too long error
                return false;
            }

            if (!(sender instanceof Player)) {
                //TODO Add not player error
                return false;
            }

            Player p = (Player) sender;

            if (!main.playerWalletMap.containsKey(p.getUniqueId())) {
                //TODO Add no economy data error
                return false;
            }

            p.sendMessage(main.playerWalletMap.get(p.getUniqueId()).getCurrency().toString());
            return true;
        }

        return false;
    }
}

 

Oh yea sorry. What you typed there is exactly what I have. Here it is if you want to see it:

Code (Text):

public void onEnable() {
        configManager = new MyConfigManager(this);
        playerEconomyData = configManager.getNewConfig("PlayerEconomyData.yml");
        messages = configManager.getNewConfig("Messages.yml");

        Bukkit.getPluginManager().registerEvents(new PlayerJoin(), this);

        getCommand("Economy").setExecutor(new Balance());
        getCommand("Economy").setTabCompleter(new Balance());

        loadEconomy();
    }

 

I did, I keep trying stuff and changing code that's why there is differences. I added it to show that I have tried it.

 

I have tried print messages on the onTabComplete and the messages do print.

 

I can get it to (sort of) work if I take the if-statements out of the onTabComplete. By sort of work I mean it gives the tab suggestions, but I need it to work with the if-statements.

 

Ok, I fixed it. It was a problem with my if-statements within my onTabComplete. Thanks for everyone who helped

I fixed it by changing:

Code (Text):

if (args.length == 0)

to:

Code (Text):

if (args.length == 1)

Not sure why that worked considering I want the tab to complete when the user hasn't entered any args, but if it works I guess I can live with it just not sure why. I guess when you hit space bar, even if you haven't typed anything the args length is still 1.

 

I don't know I'm sure "Ut enim ad minima veniam, quis nostrum exercitationem ullam corporis suscipit laboriosam, nisi ut aliquid ex ea commodi consequatur?" are works to live by.